Skip to content

Update AUTOSAR reference #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 24, 2023
Merged

Update AUTOSAR reference #297

merged 12 commits into from
May 24, 2023

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Apr 26, 2023

Description

  • Fix broken PDF link
  • List supported AUTOSAR releases: R22-11, R21-11, R20-11, R19-11 and R19-03
  • Update user manual

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

- Fix PDF link
- Drop version distinctions (no changes since 19-03 )
@mbaluda mbaluda requested a review from lcartey April 26, 2023 18:07
@mbaluda mbaluda marked this pull request as ready for review April 26, 2023 18:35
Copy link
Collaborator

@lcartey lcartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up. I've added some suggested changes along these lines:

  • Put the most recent standard first in all list.
  • Add 22-11 and 19-03 as additionally covered standards.
  • Switch the links to 22-11
  • Suggestion to add a footnote in the user manual to explain that 19-03 onwards is identical.

@mbaluda mbaluda requested a review from lcartey May 2, 2023 06:37
@mbaluda mbaluda self-assigned this May 24, 2023
@mbaluda mbaluda closed this May 24, 2023
@mbaluda mbaluda reopened this May 24, 2023
@lcartey lcartey added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit beda676 May 24, 2023
@lcartey lcartey deleted the mbaluda-autosar-link branch May 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants